In this paper, the authors made a comparative study of the geochemical characteristics of trace elements and REE for various rocks such as granites and dolerites as well as uranium ores from the Shangjiao uranium deposit of southern Jiangxi. The ore-forming material source and metallogenic model of the Shangjiao uranium deposit were discussed. Based as geological and elemental geochemical data, the authors have reached some conclusions:① The high U content and low Th/U values of early Indosinian granites and early Yanshanian granites suggest that both granites had the capability of providing adequate sources of uranium for uranium mineralization in the study area, and the potential of early Yanshanian granites for providing the sources of uranium was even greater; ② There was almost no change in the content of trace elements and REE and distribution patterns during hydromicazation of granites, but there occurred uranium enrichment and mineralization and REE remobilization during the superposition of hematitization. These phenomena imply that hematitization was more closely related to uranium mineralization in the study area; ③ The trace elements distribution patterns of dolerites show mantle characteristics, significantly different from features of granites and uranium ores, and the U content and U/Th ratios of altered dolerites are obviously higher than those of fresh dolerites, which suggests that the ore-forming material of the Shangjiao uranium deposit was not derived from dolerites. Large areas of hematitization imply that dolerites provided ore-forming components and volatiles(CH₄, CO, CO₂, H₂S and Fe²⁺) for oxidation-reduction reaction of uranium mineralization, so that the migration of U⁶⁺ experienced deoxidation to form U⁴⁺ and precipitated mineralization material; ④ The trace elements distribution patterns of uranium ores and granites show high similarity and gradual relationship, indicating that ore-forming material was derived from granites. The total REE content of uranium ores is obviously lower than that of granites and dolerites, indicating that the ore-forming fluids were characterized by a lack of REE. In combination with the geological background of mineralization, the characteristics of magmatic-structure-alteration and geochemical characteristics of trace elements, the authors have improved the metallogenic model of the deposit.